gh-gei icon indicating copy to clipboard operation
gh-gei copied to clipboard

Automatically build and release the CLI for the linux-arm64 build target

Open chtzvt opened this issue 1 year ago • 8 comments

  • [ ] Did you write/update appropriate tests
  • [x] Release notes updated (if appropriate)
  • [ ] Appropriate logging output
  • [x] Issue linked
  • [ ] Docs updated (or issue created)
  • [ ] New package licenses are added to ThirdPartyNotices.txt (if applicable)

chtzvt avatar May 01 '24 19:05 chtzvt

Unit Test Results

810 tests   810 :white_check_mark:  22s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit a95b4547.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 01 '24 19:05 github-actions[bot]

RE https://github.com/github/gh-gei/issues/1230#issuecomment-2078150261-- I've essentially made a carbon copy of Tim's commit for windows-x86, but will perform some additional testing in my fork.

chtzvt avatar May 01 '24 19:05 chtzvt

Or perhaps not... For some reason, none of the workflows in my fork appear in the Actions tab of my fork!

Would love to dispatch the CI workflow and actually test the built linux-arm64 release.

image

chtzvt avatar May 01 '24 19:05 chtzvt

Or perhaps not... For some reason, none of the workflows in my fork appear in the Actions tab of my fork!

Would love to dispatch the CI workflow and actually test the built linux-arm64 release.

When I fork repos I get this in my fork: image

dylan-smith avatar May 01 '24 19:05 dylan-smith

@dylan-smith I was able to create a separate fork of this repository, merge this PR into it, and run a modified version of the CI workflow (which removed the E2E integration tests, as their success is required for the publish step to proceed but I cannot run them).

The modified CI workflow run produced working aarch64 builds for Linux in the publish step, which I was able to verify as executable on an ARM Linux VM:

Screenshot 2024-06-26 at 16 17 30

I've invited you as an outside collaborator to that repository if you'd like to access/inspect the built artifacts on your end.

chtzvt avatar Jun 26 '24 20:06 chtzvt

I no longer work on the gei eng team (I just lurk in the repo), so one of the engineers from that team will have to shepherd this PR in.

dylan-smith avatar Jun 26 '24 23:06 dylan-smith

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 78% 73% 651
ado2gh 84% 78% 627
Octoshift 87% 76% 1272
gei 79% 70% 519
Summary 83% (6821 / 8172) 75% (1534 / 2044) 3069

github-actions[bot] avatar Sep 23 '24 15:09 github-actions[bot]