gh-copilot icon indicating copy to clipboard operation
gh-copilot copied to clipboard

Support android-arm

Open Nichokas opened this issue 2 years ago • 6 comments

Describe the need

What problem are you trying to solve? What do you want to happen?

Suport for android ARM

Version

Do these docs apply to a specific version? For example: gh-copilot v0.5.2-beta

No

Relevant terminal output

Please copy and paste any relevant terminal output. Please check your output before submission to ensure sensitive information is redacted.

Nichokas avatar Jan 15 '24 18:01 Nichokas

@Nichokas: thanks for opening up this issue!

Support android-arm

Could you share more about how you use GitHub CLI on android-arm?

I think this might be a slightly larger request as android-arm isn't one of the distributions natively supported by the GitHub CLI or cli/gh-extension-precompile.

If you are looking for mobile support, I recommend following GitHub Copilot for Mobile as I believe this has an early 2024 Q2 launch date.

andyfeller avatar Mar 21 '24 13:03 andyfeller

Sorry for the late reply, I would use it in termiux to control repositories and upload code that I have modified from termux, because if it is a private repository I cannot upload code unless I use github-cli and login

Nichokas avatar Mar 23 '24 09:03 Nichokas

Termiux is like a linux console but for android mobiles.

Nichokas avatar Mar 23 '24 09:03 Nichokas

@andyfeller I'm not sure that's true for termux. Here's where the CLI documents Android support: https://github.com/cli/cli/blob/trunk/docs/install_linux.md#android (and here it is in the termux pkg repo: https://packages.termux.dev/apt/termux-main/pool/main/g/gh/)

And here's where gh-extension-precompile supports android: https://github.com/cli/gh-extension-precompile/blob/b0da21c1042c79394bfb66a6c320bb1e360b876a/build_and_release.sh#L5-L6

And the blob is listed for the gh-copilot release: https://github.com/github/gh-copilot/releases/tag/v1.0.1

williammartin avatar Mar 25 '24 14:03 williammartin

In fact I'd like to know what's not supported here @Nichokas? What happens that this doesn't work?

williammartin avatar Mar 25 '24 15:03 williammartin

2 months ago when I reported it I didn't support android-arm but it seems that now it does

Nichokas avatar Mar 28 '24 09:03 Nichokas

@andyfeller I'm not sure that's true for termux. Here's where the CLI documents Android support: https://github.com/cli/cli/blob/trunk/docs/install_linux.md#android (and here it is in the termux pkg repo: https://packages.termux.dev/apt/termux-main/pool/main/g/gh/)

Revisiting this issue in light of #84, I think there are some nuances here I wanted to mention, @williammartin:

  1. The Android supported linked is technically unofficially provided by the Android community
  2. Our Linux and BSD support highlights that CPU architectures we generally support with a difference between 32-bit android/arm versus 64-bit android/arm64
  3. From what I understand, Termux requires a physical Android mobile device, which is somewhat difficult to reproduce support use cases

@Nichokas : would you be willing to share how you were installing github/gh-copilot with the existing release artifacts?

andyfeller avatar Jun 27 '24 13:06 andyfeller

@andyfeller I'm not sure that's true for termux. Here's where the CLI documents Android support: https://github.com/cli/cli/blob/trunk/docs/install_linux.md#android (and here it is in the termux pkg repo: https://packages.termux.dev/apt/termux-main/pool/main/g/gh/)

Revisiting this issue in light of #84, I think there are some nuances here I wanted to mention, @williammartin:

1. The Android supported linked is technically unofficially provided by the Android community

2. Our Linux and BSD support highlights that CPU architectures we generally support with a difference between 32-bit `android/arm` versus 64-bit `android/arm64`

3. From what I understand, Termux requires a physical Android mobile device, which is somewhat difficult to reproduce support use cases

@Nichokas : would you be willing to share how you were installing github/gh-copilot with the existing release artifacts?

I installed it pkg install gh image

Nichokas avatar Jun 29 '24 09:06 Nichokas

@Nichokas thanks for the response.

First I think we need to clear up some confusion, when you say "Support android-arm" are generally talking about android-arm (32-bit and 64-bit) or are you very specifically talking about 32-bit (which would generally be packaged as android-arm rather than android-arm64?

Secondly, I think Andy's question about installation was how you installed this extension, rather than gh generally.

Thanks!

williammartin avatar Jun 29 '24 09:06 williammartin

@Nichokas thanks for the response.

First I think we need to clear up some confusion, when you say "Support android-arm" are generally talking about android-arm (32-bit and 64-bit) or are you very specifically talking about 32-bit (which would generally be packaged as android-arm rather than android-arm64?

Secondly, I think Andy's question about installation was how you installed this extension, rather than gh generally.

Thanks!

The issue was on a 32bit phone and I installed the extensión with gh extension install github/gh-copilot

Nichokas avatar Jun 29 '24 15:06 Nichokas