docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix allowed contexts for reusable workflow secrets/inputs

Open matiboux opened this issue 3 months ago • 5 comments

Why:

Closes: #40391

What's being changed (if available, include any code snippets, screenshots, or gifs):

This updates the allowed contexts for jobs.<job_id>.secrets.<secret_id> and jobs.<job_id>.with.<input_id> in reusable-workflows.md to match the actual behavior and the documentation in contexts.md. This adds strategy, matrix, inputs, and vars to the allowed contexts for these keys, ensuring consistency.

This also renames placeholders in workflow keys in contexts.md to match those used in reusable-workflows.md, replacing <secrets_id> with <secret_id> and <with_id> with <input_id> for consistency.

Please verify that these changes are correct and align with the intended functionality and actual behavior of GitHub Actions.

Check off the following:

  • [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • [ ] The changes in this PR meet the docs fundamentals that are required for all content.
  • [ ] All CI checks are passing and the changes look good in the review environment.

matiboux avatar Sep 16 '25 09:09 matiboux

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Sep 16 '25 09:09 welcome[bot]

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/reference/workflows-and-actions/contexts.md fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14
actions/reference/workflows-and-actions/workflow-syntax.md fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

github-actions[bot] avatar Sep 16 '25 09:09 github-actions[bot]

Following new testing, this PR has been updated to consider the allowed expression contexts from contexts.md as the source of truth and resolve inconsistencies accordingly.

matiboux avatar Sep 16 '25 11:09 matiboux

A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment.

github-actions[bot] avatar Nov 18 '25 16:11 github-actions[bot]

If you think this pull request should remain open, please add a new comment.

Yes, this is still relevant to this day.

matiboux avatar Nov 19 '25 15:11 matiboux