docs
docs copied to clipboard
Add documentation on `on.workflow_run.workflows`
Why:
The values of on.workflow_run.workflows are treated as glob patterns. Special characters requires escaping.
Details: https://github.com/orgs/community/discussions/50835 https://github.com/actions/runner/issues/3763
Closes: #12572
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adds documentation for on.workflow_run.workflows, especially around glob patterns.
Check off the following:
- [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
- [ ] The changes in this PR meet the docs fundamentals that are required for all content.
- [ ] All CI checks are passing and the changes look good in the review environment.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
How to review these changes π
Thank you for your contribution. To review these changes, choose one of the following options:
A Hubber will need to deploy your changes internally to review.
Table of review links
β οΈ Warning: Our review server is experiencing latency issues.
The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.
| Source | Review | Production | What Changed |
|---|---|---|---|
actions/writing-workflows/workflow-syntax-for-github-actions.md |
fpt ghec ghes@ 3.16 3.15 3.14 3.13 3.12 |
fpt ghec ghes@ 3.16 3.15 3.14 3.13 3.12 |
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
π€ This comment is automatically generated.
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:
Thanks so much for opening a PR! I'll get this triaged for review.
Hi, @EnricoMi. π One of the team wanted to make sure you had seen this while we're waiting for feedback from our SMEs on this issue.
@Sharra-writes thanks for the reply! Please let the team know that I do not see the connection between the Dockerfile WORKDIR option and how Github Actions evaluates values for on.workflow_run.workflow.
@EnricoMi Well, no wonder it doesn't seem relevant, because I got my tabs mixed up and put this on the wrong pull request. π I'm so sorry, and thank you for being patient with us. I do have this open for the SMEs to look at.
Hi @EnricoMi, thanks for raising thisβI'm going to reopen the original issue so we can transfer it internally.
We'll schedule this work as soon as we can. Just so you're aware, there's a few moving parts to this and I can't guarantee that we'll use this PR: since we need to make some further changes, it may be easier for us to start a new one instead. If we do that, would you like us to add you as a co-committer? I notice you're not using noreply on your email address in your commits.
Many thanks
would you like us to add you as a co-committer
yes, please
EnricoMi:workflow_run-workflows
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle reminder for the docs team that this PR is waiting for technical review by a subject matter expert.
Hi team any updates or requirement required to close this ticket