docs icon indicating copy to clipboard operation
docs copied to clipboard

distributionManagement isn't really needed in the pom.xml file

Open sixcorners opened this issue 1 year ago • 6 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/use-cases-and-examples/publishing-packages/publishing-java-packages-with-maven

What part(s) of the article would you like to see updated?

Instead of messing with the distributionManagement xml element in the pom.xml file you could just change the mvn command to mvn --batch-mode -DaltDeploymentRepository=github::https://maven.pkg.github.com/${{ github.repository }} deploy. It's way easier than copy/paste/editing the fragment of xml and integrating it into some kind of parent pom and keeping these ids in sync. The user property is documented here: https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#altDeploymentRepository

I guess you could keep the distributionManagement stuff for people who prefer to do it that way.

Additional information

No response

sixcorners avatar Sep 29 '24 01:09 sixcorners

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Sep 29 '24 01:09 welcome[bot]

@sixcorners Thank you for raising this issue! I'll get this triaged for review :sparkles: Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

nguyenalex836 avatar Sep 30 '24 16:09 nguyenalex836

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Sep 30 '24 17:09 github-actions[bot]

I bet you could also put the altDeploymentRepository into the generated settings.xml file as a property in an activated by default profile. Not sure though

sixcorners avatar Oct 01 '24 10:10 sixcorners

Mohelgohary70 avatar Oct 06 '24 18:10 Mohelgohary70

content/admin/configuring-settings/configuring-private-networking-for-hosted-compute-products/index.md

Mohelgohary70 avatar Oct 06 '24 18:10 Mohelgohary70

Hello @sixcorners! Thank you for your patience while our SME team reviewed 💛

Upon review, Our SME team found this change would have a few considerable impacts which we are unfortunately unable to investigate further right now due to bandwidth. While we are unable to accept this contribution at this time, we appreciate your willingness to contribute! 🙇

If you're looking for other issues to work on, take a look at our help wanted section to find open issues ✨ thanks again!

nguyenalex836 avatar Oct 31 '24 22:10 nguyenalex836