docs icon indicating copy to clipboard operation
docs copied to clipboard

Update quickstart-for-actions-runner-controller.md

Open seilorjunior opened this issue 1 year ago • 7 comments

we need to be auth first, before the helm install (https://github.com/github/docs/issues/34636)

Why:

To resolve this issue https://github.com/github/docs/issues/34636

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

seilorjunior avatar Sep 18 '24 14:09 seilorjunior

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Sep 18 '24 14:09 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/quickstart-for-actions-runner-controller.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Sep 18 '24 15:09 github-actions[bot]

we need to be auth first, before the helm install (#34636)

Why:

To resolve this issue #34636

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

Hazlizam850 avatar Sep 18 '24 15:09 Hazlizam850

@seilorjunior Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Sep 18 '24 15:09 nguyenalex836

This looks great from a docs-content perspective. Once we have a confirmation from a subject matter expert, we can go ahead and merge this.

jc-clark avatar Sep 18 '24 19:09 jc-clark

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Sep 18 '24 19:09 github-actions[bot]

seilorjunior:patch-1

Ku19 avatar Sep 21 '24 22:09 Ku19

@seilorjunior Thank you for your patience while our SME team reviewed! For the reasons listed above (and in the linked issue), we are unable to accept this contribution 💛

Thank you for willingness to contribute to GitHub Docs! If you're interested, take a look at our help wanted section to find open issues you can work on ✨

nguyenalex836 avatar Oct 24 '24 14:10 nguyenalex836