github
Update countries-where-sms-authentication-is-supported.md
I added the List of Countries where services is not available
Why:
The List doesn't mention the countries where services is not available, I added a List of Countries where this services is not available Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
-
[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the
datadirectory.
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the
-
[ ] For content changes, I have completed the self-review checklist.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Automatically generated comment ℹ️
This comment is automatically generated and will be overwritten every time changes are committed to this branch.
The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.
Content directory changes
You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
| Source | Preview | Production | What Changed |
|---|---|---|---|
authentication/securing-your-account-with-two-factor-authentication-2fa/countries-where-sms-authentication-is-supported.md |
fpt ghec |
fpt ghec |
fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Secure ID Electronic Communications Sent using Ai1inTelliGenX® Evolve Apple iDevice via Android iGo-LX7 software v3.02
Stephen Craig Wilson & Associates © 2024 All Rights Reserved.
On Mon, Aug 26, 2024 at 3:22 PM Hassan Zaib Jadoon @.***> wrote:
I added the List of Countries where services is not available Why:
The List doesn't mention the countries where services is not available, I added a List of Countries where this services is not available Closes: What's being changed (if available, include any code snippets, screenshots, or gifs): Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
For content changes, I have completed the self-review checklist https://docs.github.com/en/contributing/collaborating-on-github-docs/self-review-checklist .
You can view, comment on, or merge this pull request online at:
https://github.com/github/docs/pull/34406 Commit Summary
- d569918 https://github.com/github/docs/pull/34406/commits/d569918e02ac9e2e0205dbb294dc3d45514c08c0 Update countries-where-sms-authentication-is-supported.md
File Changes
(1 file https://github.com/github/docs/pull/34406/files)
- M content/authentication/securing-your-account-with-two-factor-authentication-2fa/countries-where-sms-authentication-is-supported.md https://github.com/github/docs/pull/34406/files#diff-329129b62240486aeeb2769a895688be08fe4c972de8456158619391811e3586 (106)
Patch Links:
- https://github.com/github/docs/pull/34406.patch
- https://github.com/github/docs/pull/34406.diff
— Reply to this email directly, view it on GitHub https://github.com/github/docs/pull/34406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVJXZMLE6K7GGEIOJQLIGQ3ZTOFBZAVCNFSM6AAAAABNEWYCBSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DONRZHAZDSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@hzjadoon Thank you for opening a PR! I'll get this triaged for review ✨
Thanks for your interest in the GitHub docs, @hzjadoon; however, unfortunately we can't accept this submission.
As you've pointed out: the page already contains the information on which countries are supported, and as a matter of practice we'd normally only document the positive case and not specifically call out the negative one, as we already have done here.
I'd recommend opening an issue in future first for a better experience all round, just so we can offer feedback on how worthwhile a change or addition is before you go ahead and raise a PR. Alternatively, you can take one of the issues that are already marked as help wanted.
Thanks again!
