docs icon indicating copy to clipboard operation
docs copied to clipboard

Update telling-git-about-your-signing-key.md

Open alexmazaltov opened this issue 1 year ago • 4 comments

add alternative command for fish shell

Why: cause it is not obvious how to deal with gpg signature using fish shell

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

alexmazaltov avatar Aug 26 '24 04:08 alexmazaltov

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Aug 26 '24 04:08 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Aug 26 '24 04:08 github-actions[bot]

@alexmazaltov Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Aug 27 '24 15:08 nguyenalex836

@nguyenalex836 thank you for your time

alexmazaltov avatar Aug 29 '24 18:08 alexmazaltov

@nguyenalex836 please review

alexmazaltov avatar Sep 01 '24 09:09 alexmazaltov

Hi @alexmazaltov, and thanks for your submission and interest in the docs—

As a rule, we target Bash. I think we can make that fact clearer in our contributing documentation and I'll discuss that internally. There are potentially many more places other than this one where we could add examples that are specific to other shells, and unless there's a very specific reason to call one out in particular, we wouldn't make an exception, so for that reason I'm afraid we won't be accepting this submission right now.

I'd recommend opening an issue in future first for a better experience all round, just so we can offer feedback on how worthwhile a change or addition is before you go ahead and raise a PR. Alternatively, you can take one of the issues that are already marked as help wanted.

Thank you again!

subatoi avatar Sep 02 '24 08:09 subatoi