docs icon indicating copy to clipboard operation
docs copied to clipboard

Patch 1

Open jaceksocha opened this issue 1 year ago • 6 comments
trafficstars

Why:

Closes:

The recepie to generate JWT using bash not working when using "Client id" as "iss" , because of "Client id" is string and reqire quotes.

Result of usage token usage cause error:

{ "message": "A JSON web token could not be decoded", "documentation_url": "https://docs.github.com/rest", "status": "401" }

Example decoded payload data for JWT token generated using "Clinet id" as "iss"

"{\n \"iat\":1720435516,\n \"exp\":1720436176,\n \"iss\":Iv23liUdv*******\n}"

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • Tested locally

jaceksocha avatar Jul 08 '24 13:07 jaceksocha

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jul 08 '24 13:07 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Jul 08 '24 13:07 github-actions[bot]

@jaceksocha Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Jul 08 '24 17:07 nguyenalex836

Hi @nguyenalex836

To make sure (if not stuck on missing action on my side), should I take some action or simply wait patiently for review ?

Greetings

jaceksocha avatar Jul 23 '24 11:07 jaceksocha

@jaceksocha Hello! 👋 No action needed on your end - you'll be notified as soon as our team reviews your PR 💛 thank you for your patience!

nguyenalex836 avatar Jul 23 '24 16:07 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Jul 30 '24 06:07 github-actions[bot]

@jaceksocha Thank you very much for your patience while our SME team reviewed your PR! Your changes look great ✨ I'll update the branch and get this merged once tests are passing 🍏

nguyenalex836 avatar Aug 15 '24 17:08 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Aug 15 '24 17:08 github-actions[bot]