docs
docs copied to clipboard
Mismatch between explanation and code about triggers used
Code of Conduct
- [X] I have read and agree to the GitHub Docs project's Code of Conduct
What article on docs.github.com is affected?
Publishing Docker images (https://docs.github.com/en/actions/publishing-packages/publishing-docker-images)
What part(s) of the article would you like to see updated?
- In the section "Publishing images to Docker Hub" it says:
The workflow in the example below runs when the release event triggers with the created activity type.
while the code uses the published activity type:
on:
release:
types: [published]
- In the section Publishing images to GitHub Packages is says:
The workflow in the example below runs when the release event triggers with the created activity type.
while the code uses a push trigger:
on:
push:
branches: ['release']
Additional information
No response
@carlos-quintero Thank you for opening an issue! I'll get this triaged for review ✨
@carlos-quintero - Thank you for raising this. It would be good to correct the workflow triggers in the https://docs.github.com/en/actions/publishing-packages/publishing-docker-images article, as per the details you've given above.
I've marked this issue help-wanted. If you (or anyone else reading this) would like to raise a pull request to update the docs accordingly that would be great.
Information about contributing to the docs: https://docs.github.com/en/contributing
I've now reviewed the PR that will close this issue: https://github.com/github/docs/pull/33783