docs icon indicating copy to clipboard operation
docs copied to clipboard

Artifact attestation needs `id-token: write` permission in publishing-docker-images.md

Open thawn opened this issue 1 year ago • 3 comments

Why:

Following the current version of the documentation (without the id-token: write permission) I am getting the following error message in the attest-build-provenance step: Failed to get ID token: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable

the documentation of attest-build-provenance mentions that we also need the id-token: write permission.

Therefore, I suggest to add that to the documentation for publishing-docker-images.md

Closes: #32933

What's being changed (if available, include any code snippets, screenshots, or gifs):

added id-token: write to the permissions: section of the example yml files.

Source Preview Production What Changed
actions/publishing-packages/publishing-docker-images.md fpt ghec ghes@ 3.12 3.11 3.10 3.9 fpt ghec ghes@ 3.12 3.11 3.10 3.9 added id-token: write to the permissions: section of the example yml code
packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions.md fpt ghec ghes@ 3.12 3.11 3.10 3.9 fpt ghec ghes@ 3.12 3.11 3.10 3.9 added id-token: write to the permissions: section of the example yml code

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

thawn avatar May 13 '24 15:05 thawn

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar May 13 '24 15:05 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-docker-images.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
from reusable

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar May 13 '24 15:05 github-actions[bot]

@thawn Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar May 13 '24 21:05 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jun 01 '24 00:06 github-actions[bot]