docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix publishing-docker-images.md workflow samples

Open CosminLazar opened this issue 9 months ago • 4 comments

Why:

The actions/attest-build-provenance requires id-token: write permissions.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Just added the id-token: write to the permissions of the workflow showed as an example.

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

CosminLazar avatar May 06 '24 20:05 CosminLazar

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar May 06 '24 20:05 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-docker-images.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar May 06 '24 20:05 github-actions[bot]

@CosminLazar Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar May 06 '24 21:05 nguyenalex836

Kendarigaul:patch-1

dxkf177 avatar May 11 '24 13:05 dxkf177

Hey @CosminLazar, thank you so much for catching this and updating the docs! I came across https://github.com/github/docs/pull/32926 before I saw your PR, which made the exact same changes. Since I merged that PR, I'm just going to close this one out. Thanks again for helping us improve our docs. 💛

SiaraMist avatar Jun 01 '24 00:06 SiaraMist