docs icon indicating copy to clipboard operation
docs copied to clipboard

PR - Adding imagePullSecrets into the template spec gha-runner-scale-set/v…

Open leandromsft opened this issue 1 year ago • 3 comments
trafficstars

This pull request includes a change to the content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md file. The change adds imagePullSecrets to the template: section, which allows the specification of a secret name for pulling images from a private registry. This is a significant addition as it enhances the security of image pulls in self-hosted runner deployments.

Here's a summary of the change:

  • content/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md: Added imagePullSecrets under the template: section to specify a secret name for pulling images from a private registry.

leandromsft avatar Mar 14 '24 18:03 leandromsft

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Mar 14 '24 18:03 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/deploying-runner-scale-sets-with-actions-runner-controller.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Mar 14 '24 18:03 github-actions[bot]

@leandromsft Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Mar 14 '24 20:03 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar May 16 '24 18:05 github-actions[bot]