docs icon indicating copy to clipboard operation
docs copied to clipboard

Update githubs-plans.md

Open llschall opened this issue 1 year ago • 5 comments
trafficstars

Add GitHub pages in the free version

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

llschall avatar Feb 28 '24 21:02 llschall

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 28 '24 21:02 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/learning-about-github/githubs-plans.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Feb 28 '24 21:02 github-actions[bot]

Hi GitHub team,

The pages documentation precises that the GitHub Pages "is available in public repositories with GitHub Free", in the second part of the "Who can use this feature?" section at the beginning.

But in the GitHub plans the GitHub pages are only mentioned in the pro version for instance, but not in the "GitHub Free for personal accounts".

So to align with the documentation, and clarify if GitHub pages can be used with a free personal account as well, this pull request consists in adding the GitHub pages in the free personal account section.

Thanks in advance for evaluating this.

Best Regards, Laurent

llschall avatar Feb 28 '24 21:02 llschall

@llschall Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 28 '24 21:02 nguyenalex836

The staging environment correctly shows the change to be evaluated.

llschall avatar Feb 28 '24 21:02 llschall

[maintainer edit for spammy content]

Stephenson131313 avatar Mar 02 '24 06:03 Stephenson131313

@llschall Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

nguyenalex836 avatar Mar 13 '24 21:03 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 13 '24 22:03 github-actions[bot]