docs
docs copied to clipboard
workflow-syntax-for-github-actions.md: services.image: document empty image
Why:
Closes: N/A
What's being changed (if available, include any code snippets, screenshots, or gifs):
This is a follow-up of GH Actions community discussion #109389 - Conditional GHA jobs services
and documents this undocumented solution that works great đ.
In the absence of jobs.<job_id>.services.<service_id>.if
, this ''
behavior is extremely useful and I would have loved to find it in the doc.
Here it is! Preview deployment:
Check off the following:
- [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the
data
directory.
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the
- [x] For content changes, I have completed the self-review checklist.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
Automatically generated comment âšī¸
This comment is automatically generated and will be overwritten every time changes are committed to this branch.
The table contains an overview of files in the content
directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data
directory will not show up in this table.
Content directory changes
You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
Source | Preview | Production | What Changed |
---|---|---|---|
actions/using-workflows/workflow-syntax-for-github-actions.md |
fpt ghec ghes@ 3.12 3.11 3.10 3.9 3.8 |
fpt ghec ghes@ 3.12 3.11 3.10 3.9 3.8 |
fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server
@ reviewers: preview deployment okay!
@ronjouch Thanks so much for opening a PR! I'll get this triaged for review â¨
@ronjouch Hello, and thank you for patience while our team reviewed! đ After review, our team assessed this seems to be a very specific case. We are unable to cover every edge case in our documentations, and will not be able to add this update đ
I'm going to go ahead and close this PR now. Thank you for your interest in improving the docs! â¨
After review, our team assessed this seems to be a very specific case. We are unable to cover every edge case in our documentations, and will not be able to add this update
@nguyenalex836 I beg to differ. This is not "edge case" land to me, it's the only way I was able to make my service
conditional. Without lucking out on getting the tip about ''
from the community, I'd have had no idea this was feasible đ.
I'd love if GHA had explicit support for conditional services, but in doesn't. Until it does, please reconsider documenting this.
Hey @ronjouch, thank you for responding to us. We've shown your response to the team, and they've agreed that it is okay to document this functionality. We updated the text to match our style guide, and will get this PR merged!
Thank you for your care while contributing to GitHub docs. đ
Thanks very much for contributing! Your pull request has been merged đ You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:
Hey @ronjouch, thank you for responding to us. We've shown your response to the team, and they've agreed that it is okay to document this functionality. We updated the text to match our style guide, and will get this PR merged! Thank you for your care while contributing to GitHub docs. đ
@SiaraMist thanks for listening and reconsidering! Confirmed shipped.