docs icon indicating copy to clipboard operation
docs copied to clipboard

Some exception that might not work

Open JJ opened this issue 1 year ago • 1 comments
trafficstars

Why:

Well, I've spent the best part of the morning trying to find out why this happened; I got to raise this issue but at any rate it's easier to fix the documentation than fixing the issue. The issue should be right around this line https://github.com/benbalter/jekyll-relative-links/blob/9f05f8524cd974fc151d0d960ae3ad2e4935d3c6/lib/jekyll-relative-links/generator.rb#L52, and I might try to fix it some time in the future, but meanwhile I (or someone else) gets around to do it, gets fixed, and deployed downstream to GitHub pages (which is where I use), this little fix can help lost souls like myself save a bit of time, right? Lots of love to you and all the world in this Valentine day!

Closes:

Does not really close, but mitigates https://github.com/benbalter/jekyll-relative-links/issues/93

What's being changed (if available, include any code snippets, screenshots, or gifs):

Just adding an exception to the example.

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

JJ avatar Feb 14 '24 09:02 JJ

@JJ Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 14 '24 20:02 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 25 '24 13:03 github-actions[bot]