docs icon indicating copy to clipboard operation
docs copied to clipboard

Update leave-feedback-with-pull-requests.md

Open BaeztheProg opened this issue 1 year ago • 3 comments
trafficstars

Added additional steps for clarification on student work review.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

BaeztheProg avatar Feb 02 '24 19:02 BaeztheProg

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 02 '24 19:02 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
education/manage-coursework-with-github-classroom/teach-with-github-classroom/leave-feedback-with-pull-requests.md fpt
fpt

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Feb 02 '24 19:02 github-actions[bot]

@BaeztheProg Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 02 '24 20:02 nguyenalex836

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Mar 22 '24 16:03 github-actions[bot]

Thank you for taking the time to look into this and sharing the suggested changes and the video of the flow. I think this will be very helpful for the community that is using github classroom.

Let me know if there is anything left to be done on my part.

Best,

Miguel Baez

On Wed, Mar 27, 2024 at 7:59 AM Nikka Padilla @.***> wrote:

@.**** commented on this pull request.

Left a suggestion and added a recording to see the new flow and make sure our docs match the new user interface. I'm not familiar with the variables used here so I looked up what the current article https://docs.github.com/en/education/manage-coursework-with-github-classroom/teach-with-github-classroom/leave-feedback-with-pull-requests#leaving-feedback-in-a-pull-request-for-an-assignment renders and compared the changes in this PR. Thanks for working on this! ✨

In content/education/manage-coursework-with-github-classroom/teach-with-github-classroom/leave-feedback-with-pull-requests.md https://github.com/github/docs/pull/31419#discussion_r1541257008:

+1. For the student to review press the feedback button to the right of the student row. +1. On the Feedback PR select the Files Changed tab. +2. Annotate, review and submit commentary for the student.

  1. To the right of the submission, click Review.
  2. Review the pull request. For more information, see "AUTOTITLE."

⬇️ Suggested change

-1. For the student to review press the feedback button to the right of the student row. -1. On the Feedback PR select the Files Changed tab. -2. Annotate, review and submit commentary for the student. -1. To the right of the submission, click Review. -1. Review the pull request. For more information, see "AUTOTITLE." +1. Each student will have a submission row, press the Feedback link to navigate to the student's pull request. +1. On the Feedback PR select the Files changed tab. +1. Review the pull request. For more information, see "AUTOTITLE."

Sharing a recording of what this flow currently looks like:

https://github.com/github/docs/assets/1108003/8674f822-475e-4ac7-9ab1-0447aae4e2fa

— Reply to this email directly, view it on GitHub https://github.com/github/docs/pull/31419#pullrequestreview-1963559935, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDLD27VLKFZWN4X3XOZ7IIDY2LNELAVCNFSM6AAAAABCXF3CYGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRTGU2TSOJTGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Best,

Miguel Baez DHS/EHS Ed Tech Coach Career Technical Education -- CS

BaeztheProg avatar Mar 27 '24 17:03 BaeztheProg

@BaeztheProg Thanks so much for committing those suggestions! ✨ I'll update the branch and get this merged once tests are passing 🍏

nguyenalex836 avatar Mar 27 '24 17:03 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 27 '24 17:03 github-actions[bot]