docs icon indicating copy to clipboard operation
docs copied to clipboard

Include `ports` Config in Postgres Service Container Docs

Open awmichel opened this issue 1 year ago • 3 comments
trafficstars

Why:

Closes: TBD

What's being changed (if available, include any code snippets, screenshots, or gifs):

The ports config was included in the two later examples in this guide, but omitted from the initial examples. Due to copypasta, we spent half a day trying to figure out why the action steps couldn't connect to the Postgres service container. 🤦

I don't see a strong case for not keeping the service definition consistent across all examples, there's nothing different between them otherwise and there's no sense of building to a complete config throughout the article.

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

awmichel avatar Feb 01 '24 22:02 awmichel

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 01 '24 22:02 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-containerized-services/creating-postgresql-service-containers.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] avatar Feb 01 '24 22:02 github-actions[bot]

@awmichel Thanks so much for opening a PR! I'll get this triaged for review ✨

nguyenalex836 avatar Feb 01 '24 23:02 nguyenalex836

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 01 '24 23:03 github-actions[bot]