docs icon indicating copy to clipboard operation
docs copied to clipboard

Add OpenID Connection configuration for Alibaba Cloud

Open JacksonTian opened this issue 1 year ago â€ĸ 13 comments

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [ ] For content changes, I have completed the self-review checklist.

JacksonTian avatar Nov 13 '23 06:11 JacksonTian

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Nov 13 '23 06:11 welcome[bot]

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* src//scripts/** src/.json src/workflows/ lib/redirects/** package.json content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Nov 13 '23 06:11 github-actions[bot]

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
New file: actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-alibaba-cloud.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
actions/deployment/security-hardening-your-deployments/index.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Nov 13 '23 06:11 github-actions[bot]

Why can't contribute the content/actions/deployment/security-hardening-your-deployments/**.

JacksonTian avatar Nov 13 '23 06:11 JacksonTian

Hope someone can help me.

JacksonTian avatar Nov 13 '23 07:11 JacksonTian

@JacksonTian Thanks for your interest in contributing to the Docs and for submitting a PR! ✨

We have built in security checks for any changes made to potentially sensitive files, like the security hardening files you are attempting to change in this PR. They will require an extra review before being considered for acceptance.

For future reference, in cases like this where you are adding a new article or guide, we encourage you to open an issue first. That way, we can review the need for your proposed addition before you submit your PR. That will greatly improve the review experience for both sides of the PR. 👍

I'll run this by our team and get it up for review 👀

cmwilson21 avatar Nov 13 '23 15:11 cmwilson21

@cmwilson21 Thank you for your feedback.

JacksonTian avatar Nov 14 '23 13:11 JacksonTian

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Nov 14 '23 15:11 github-actions[bot]

Hello, any feedbacks?

JacksonTian avatar Nov 28 '23 06:11 JacksonTian

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Feb 14 '24 16:02 github-actions[bot]

Hey @JacksonTian, thank you so much for writing this article and opening an PR to add it to our docs! ✨

Do you know if there is any Alibaba doc that can be cross referenced for GitHub OIDC integration? After checking with our engineering team, we are hoping to use this to internally verify an Alibaba set up.

SiaraMist avatar Feb 20 '24 22:02 SiaraMist

Hello @SiaraMist . The article https://www.alibabacloud.com/help/en/ram/user-guide/overview-of-oidc-based-sso describes how to use OIDC on Alibaba Cloud.

And we have a GitHub Action https://github.com/aliyun/configure-aliyun-credentials-action to integrate with GitHub OIDC.

Thanks for your feedback.

JacksonTian avatar Feb 21 '24 07:02 JacksonTian

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Mar 30 '24 16:03 github-actions[bot]

Hey @JacksonTian, thank you so much for your patience as the team works through our backlog. 💛

I took your PR and the configuration documents you sent back to the team for review. They suggested that we add links to the Alibaba Cloud information from another article instead of adding this new one. I've gone ahead and opened a PR for that, and you can see the Alibaba Cloud mentions here and here.

I'm going to close out this PR in favor of those changes. We really appreciate your thoughtful contribution to the GitHub docs. ✨

SiaraMist avatar May 23 '24 18:05 SiaraMist