docs icon indicating copy to clipboard operation
docs copied to clipboard

CODEOWNERS displays error to anonymous

Open dan2k3k4 opened this issue 1 year ago • 2 comments

Code of Conduct

What article on docs.github.com is affected?

If you visit https://github.com/github/docs/blob/main/.github/CODEOWNERS, you'll notice the linting error visible:

Unknown owner on line 10: make sure the team @github/oidc exists, is publicly visible, and has write access to the repository

…hardening-your-deployments/** @github/oidc

It is visible whether you're logged in or out of GitHub.

image

What changes are you suggesting?

Suggestion:

  • Hide linting errors unless you're either logged in to GitHub or have write access to the file

Perhaps, also set the team @github/oidc as public to fix the initial linting error.

Additional information

No response

dan2k3k4 avatar Jun 22 '23 13:06 dan2k3k4

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 22 '23 13:06 welcome[bot]

@dan2k3k4 Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

cmwilson21 avatar Jun 22 '23 20:06 cmwilson21

👋 ! That's expected with our setup:

https://github.com/github/docs/blob/b0b1a121f20a49ad3e97a010a4ee048333015043/README.md#L5

So internally in the private repo we might have some teams that will review particular changes but those teams won't be publicly visible.

rsese avatar Jun 27 '23 19:06 rsese

Closing this issue per comment above 💛

Please take a look at our help wanted section to find open issues you can work on.

Thank you for your interest in improving GitHub Docs! :sparkling_heart:

cmwilson21 avatar Jun 30 '23 14:06 cmwilson21