docs icon indicating copy to clipboard operation
docs copied to clipboard

Add guide for setting up php codespaces

Open garrettw opened this issue 1 year ago • 6 comments

Why:

There is already a PHP template for Codespaces, but no guide to match.

Closes: #25719

What's being changed (if available, include any code snippets, screenshots, or gifs):

added an article, though I'll need help or guidance on getting the necessary screenshots added in

Check off the following:

  • [ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [ ] For content changes, I have completed the self-review checklist.

garrettw avatar May 26 '23 22:05 garrettw

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar May 26 '23 22:05 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/guides.md fpt
ghec
fpt
ghec
codespaces/index.md fpt
ghec
fpt
ghec
codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/index.md fpt
ghec
fpt
ghec
New file: codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/setting-up-your-php-project-for-codespaces.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar May 26 '23 22:05 github-actions[bot]

Hmm, none of my changes are visible on the preview links. What have I missed?

garrettw avatar May 27 '23 01:05 garrettw

@garrettw Thanks for opening an issue and linking it to your PR! ⚡

We appreciate your time with this. I'll get it triaged for review ✨

However, I'm unsure about the error in the preview. We'll look into that a bit more and hopefully find an answer for you 💖

cmwilson21 avatar May 31 '23 19:05 cmwilson21

@garrettw - Many thanks for raising this PR.

The preview for this wasn't working because the new article needed to be added to the index.md file for https://docs-25720-f52a5e.preview.ghdocs.com/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration. I've added this now.

I'll take a look at this PR and check with product management about adding the new article. Thanks again for your work on this. 👍

hubwriter avatar Jun 01 '23 08:06 hubwriter

@garrettw - please move this PR out of the Draft state when it's ready for a re-review. Thanks.

hubwriter avatar Jun 14 '23 14:06 hubwriter

👋 Hey @garrettw - just wanted to check in and see if this is ready for re-review? No rush, just didn't want it to fall off the radar 👍

cmwilson21 avatar Jul 06 '23 03:07 cmwilson21

Namber only go od

احصل على Outlook’s لـ iOShttps://aka.ms/o0ukef


من: afeeq19 @.> ‏‏تم الإرسال: Saturday, July 8, 2023 5:08:19 AM إلى: github/docs @.> نسخة: Subscribed @.***> ‏‏الموضوع: Re: [github/docs] Add guide for setting up php codespaces (PR #25720)

@afeeq19 commented on this pull request.

good job

— Reply to this email directly, view it on GitHubhttps://github.com/github/docs/pull/25720#pullrequestreview-1520414841, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AS3XTAWWPCIRBIOYGRDDL53XPC6JHANCNFSM6AAAAAAYQYNRFI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

mohmadalabdalui avatar Jul 08 '23 08:07 mohmadalabdalui

Not sure why it refuses to deploy when I push a commit. I guess someone else will have to do it again.

garrettw avatar Jul 22 '23 04:07 garrettw

www.google.com

Jhoine avatar Jul 24 '23 08:07 Jhoine

#26976

Jhoine avatar Jul 24 '23 08:07 Jhoine

Details

Jhoine avatar Jul 24 '23 08:07 Jhoine

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Aug 02 '23 10:08 github-actions[bot]