docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix Text

Open Sriparno08 opened this issue 1 year ago â€ĸ 3 comments

Why:

This change will allow users to use the right command.

Closes:

#25314

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have changed:

  • theme: THEME-NAME to theme: jekyll-theme-THEME-NAME
  • theme: minima to theme: jekyll-theme-minima

GitHub Docs URL: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll

Check off the following:

  • [x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [x] For content changes, I have completed the self-review checklist.

Sriparno08 avatar May 09 '23 15:05 Sriparno08

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/setting-up-a-github-pages-site-with-jekyll/adding-a-theme-to-your-github-pages-site-using-jekyll.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar May 09 '23 15:05 github-actions[bot]

@Sriparno08 Thanks for submitting a PR! I'm going to triage this but place it on hold per comment here as we investigate it a bit further. 👍

cmwilson21 avatar May 10 '23 14:05 cmwilson21

Hey @cmwilson21, is there any update on the PR?

Sriparno08 avatar Jun 25 '23 18:06 Sriparno08

@Sriparno08 Thanks for checking in! Sorry for the delay, we've had to do a bit of digging as to why this doesn't work for all themes. Still working on it, though!

cmwilson21 avatar Jul 06 '23 03:07 cmwilson21

Its OK, @cmwilson21 👍

Thanks for the update!

Sriparno08 avatar Jul 06 '23 03:07 Sriparno08

Hey @cmwilson21, is there any update?

Sriparno08 avatar Oct 03 '23 07:10 Sriparno08

We're having a small problem with our preview deployments at this moment, once that's resolved I'll double check these changes on preview and then get this merged if all looks good! ⚡

vgrl avatar Nov 10 '23 01:11 vgrl

Okay, @vgrl 👍

Sriparno08 avatar Nov 10 '23 03:11 Sriparno08

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Nov 13 '23 22:11 github-actions[bot]