docs icon indicating copy to clipboard operation
docs copied to clipboard

Update sudo-mode.md

Open adamrr724 opened this issue 1 year ago • 5 comments

Why: Sudo Mode session timeout should be updated to explicitly state the session length.

Closes: https://github.com/github/docs/issues/25141

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [ ] For content changes, I have completed the self-review checklist.

adamrr724 avatar Apr 20 '23 23:04 adamrr724

updating this documentation based on this conversation with engineering: https://github.com/github/authnd/issues/1895#issuecomment-1516968032

adamrr724 avatar Apr 20 '23 23:04 adamrr724

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/sudo-mode.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Apr 20 '23 23:04 github-actions[bot]

👋 @adamrr724 Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! :zap:

cmwilson21 avatar Apr 21 '23 18:04 cmwilson21

Hi @adamrr724, just checking whether you're still planning to get this merged?

isaacmbrown avatar May 15 '23 14:05 isaacmbrown

Hey there, sorry missed this @isaacmbrown -- this is specifically for GHES, so let's only add it to the GHES docs!

adamrr724 avatar May 16 '23 20:05 adamrr724

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jul 12 '23 14:07 github-actions[bot]