docs icon indicating copy to clipboard operation
docs copied to clipboard

Update workflow-commands-for-github-actions.md

Open MayCXC opened this issue 2 years ago • 6 comments

Why:

The behavior I currently see in workflows is that outputs are not present when not defined in a job, like they were in this example.

What's being changed (if available, include any code snippets, screenshots, or gifs):

workflow docs example

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

MayCXC avatar Apr 06 '23 23:04 MayCXC

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Apr 06 '23 23:04 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Apr 06 '23 23:04 github-actions[bot]

reopening after testing more, looks like the job outputs are empty when set up like this example, and it contradicts: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

MayCXC avatar Apr 07 '23 15:04 MayCXC

Thanks for the PR @MayCXC, I'll get this triaged for review.

steveward avatar Apr 12 '23 16:04 steveward

Por qué:

El comportamiento que veo actualmente en los flujos de trabajo es que las salidas no están presentes cuando no están definidas en un trabajo, como en este ejemplo.

Qué se está cambiando (si está disponible, incluya fragmentos de código, capturas de pantalla o gifs):

ejemplo de documentos de flujo de trabajo

Marque lo siguiente:

  • [x] He revisado mis cambios en la puesta en escena (busque el "Comentario generado automáticamente" y haga clic en los enlaces en la columna "Vista previa" para ver sus últimos cambios).
  • [x] Para los cambios de contenido, he completado la lista de verificación de autoevaluación . Bueno

Coinsintegrity avatar May 22 '23 12:05 Coinsintegrity

Buenos argumentos

Coinsintegrity avatar May 22 '23 12:05 Coinsintegrity

Hi @MayCXC Thanks for your contribution! Can you heed @sabrowning1 's suggestion and then I think we can finish the review of this. Thanks in advance!

peterbe avatar Oct 23 '23 14:10 peterbe

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Oct 24 '23 12:10 github-actions[bot]