docs icon indicating copy to clipboard operation
docs copied to clipboard

clarify that `if` operates before `matrix`

Open jsoref opened this issue 2 years ago • 3 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif

What part(s) of the article would you like to see updated?

You can use the jobs.<job_id>.if conditional to prevent a job from running unless a condition is met. You can use any supported context and expression to create a conditional. For more information on which contexts are supported in this key, see "Contexts."

Add a paragraph noting that matrix operates after if.

Additional information

https://github.com/community/community/discussions/48705

jsoref avatar Mar 14 '23 23:03 jsoref

👋 Hey @jsoref - Thanks for the issue! I'll triage it for review 👀

cmwilson21 avatar Mar 15 '23 13:03 cmwilson21

@cmwilson21 😢

jsoref avatar May 21 '23 16:05 jsoref

@jsoref Sorry about that! Stalebot has been getting the jump on me recently! Reopening it now 💖

cmwilson21 avatar May 22 '23 20:05 cmwilson21

@cmwilson21 😞

jsoref avatar Jul 30 '23 16:07 jsoref

@jsoref got it! Sorry about that!

cmwilson21 avatar Jul 31 '23 13:07 cmwilson21

@jsoref - Thanks for raising this issue based on the community post. I think this is worth clarifying in https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif.

Markdown file: https://github.com/github/docs-internal/blob/main/data/reusables/actions/jobs/section-using-conditions-to-control-job-execution.md?plain=1

I've marked this issue help-wanted. A PR for this, based on the information provided about, would be gratefully received, if you (or anyone else reading this) are able to do so. 👍

hubwriter avatar Jul 31 '23 13:07 hubwriter

@cmwilson21 I've created https://github.com/github/docs/pull/27168 which would probably result in me being slightly less frustrated with this repository. I understand that some other bot will shoot it, but I'm hoping that you can see about applying some similar change to the workflow.

jsoref avatar Jul 31 '23 13:07 jsoref

@hubwriter I presume you mean https://github.com/github/docs/blob/main/data/reusables/actions/jobs/section-using-conditions-to-control-job-execution.md?plain=1 as I don't (at this time) have access to github/docs-internal.

jsoref avatar Jul 31 '23 13:07 jsoref