docs icon indicating copy to clipboard operation
docs copied to clipboard

[REST] Activity Types list for pull_request appears stale

Open jsoref opened this issue 2 years ago • 4 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

What part(s) of the article would you like to see updated?

The list of activity types appears stale:

  • assigned
  • unassigned
  • labeled
  • unlabeled
  • opened
  • edited
  • closed
  • reopened
  • synchronize
  • converted_to_draft
  • ready_for_review
  • locked
  • unlocked
  • review_requested
  • review_request_removed
  • auto_merge_enabled
  • auto_merge_disabled

At least milestoned is missing...

Additional information

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request

assigned auto_merge_disabled auto_merge_enabled closed converted_to_draft demilestoned dequeued edited enqueued labeled locked milestoned opened ready_for_review reopened review_request_removed review_requested synchronize unassigned unlabeled unlocked

image

jsoref avatar Feb 14 '23 07:02 jsoref

👋 @jsoref Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

cmwilson21 avatar Feb 14 '23 14:02 cmwilson21

@cmwilson21: the stale bot appears to have become considerably ruder.

jsoref avatar Apr 23 '23 01:04 jsoref

@jsoref Thanks for pinging me. Reopening now! 👍

cmwilson21 avatar Apr 24 '23 15:04 cmwilson21

The milestoned event is definitely being triggered for pull requests.

I didn’t check demilestoned, but I doubt one would be added without the other.

flying-sheep avatar Jun 19 '23 15:06 flying-sheep

please reopen and pin (never-stale label)

flying-sheep avatar Aug 25 '23 18:08 flying-sheep

@cmwilson21 can you please reopen and add a label that prevents your bots from closing it again?

flying-sheep avatar Nov 03 '23 16:11 flying-sheep

@flying-sheep Got it, thanks for the ping!

cmwilson21 avatar Nov 03 '23 17:11 cmwilson21

Thx for spotting this @jsoref! 👏 I've opened a PR with the fix. Seems that milestoned and demilestoned were added at some point, so there were just a couple other additions needed to bring it up to date.

mark-mxwl avatar Dec 16 '23 17:12 mark-mxwl