docs icon indicating copy to clipboard operation
docs copied to clipboard

'cleanup caches' example workflow is wrong and harmful!

Open andreasabel opened this issue 2 years ago â€ĸ 2 comments

It will delete the caches of the base branch, not the PR branch. Needs fixing! I added an alert in comments that this example doesn't work.

Evidence here: https://github.com/agda/agda/actions/runs/4025940394/jobs/6919801891#step:3:5 (Note: these logs will be removed by github after some time.)

andreasabel avatar Jan 27 '23 16:01 andreasabel

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jan 27 '23 16:01 welcome[bot]

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes@ 3.7 3.6 3.5
fpt
ghec
ghes@ 3.7 3.6 3.5

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jan 27 '23 16:01 github-actions[bot]

@andreasabel Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Jan 30 '23 16:01 cmwilson21

@andreasabel Actually after looking at it, this PR would be better opened as issue as this is a report of a discrepancy. So I'm going to go ahead and close this PR. 💛

Would you mind taking the information in your note and creating a new issue with it? Then I can get this properly triaged and up for review 👍

cmwilson21 avatar Jan 30 '23 16:01 cmwilson21

@cmwilson21 : Ok, Courtney, I opened an issue instead:

  • #23600

(This is my first report here, so I don't know my ways around here yet. Initially, I followed the "Contribute" button in the docs which brought me to the editor to open a PR.)

andreasabel avatar Jan 31 '23 10:01 andreasabel

@andreasabel Sounds great! Take a look at the contributing.md if you want to explore further for future contributions 😄

cmwilson21 avatar Jan 31 '23 15:01 cmwilson21