docs icon indicating copy to clipboard operation
docs copied to clipboard

Link users to Multiline strings section

Open dawei-wang opened this issue 2 years ago • 2 comments

Fixes github/docs#21529

Why:

Closes github/docs#21529

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

dawei-wang avatar Jan 05 '23 20:01 dawei-wang

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jan 05 '23 21:01 github-actions[bot]

@dawei-wang Thanks for submitting a PR with this fix! I'll get this triaged for review ⚡

cmwilson21 avatar Jan 06 '23 14:01 cmwilson21

Closing this for 5 mins or so as the Deploy Preview Environment test seems to be unhappy.

mchammer01 avatar Feb 07 '23 16:02 mchammer01

@dawei-wang 👋 - Just checking in. Have you had a chance to think about adding an example per the request here?

cmwilson21 avatar Feb 21 '23 22:02 cmwilson21

Going to go ahead and merge the content change and a contributor will add an example later

cmwilson21 avatar Mar 30 '23 14:03 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Mar 30 '23 14:03 github-actions[bot]

@cmwilson21 why is this merged? I've just spent several hours trying to get it working without success and it is absolutely frustrating

steps:
    - id: submit
      name: submit deploy
      shell: bash
      env:
        GITHUB_TOKEN: "${{ inputs.gh_token }}"
        PULUMI_STACK: ${{inputs.app_environment}}
        APP: ${{inputs.app_name || inputs.app_environment }}
        REF: ${{ inputs.branch || github.ref }}
      run: |
        response=$(curl --silent --show-error --fail \
          -X POST "https://api.github.com/repos/$GITHUB_REPOSITORY/deployments" \
          -H "Authorization: token $GITHUB_TOKEN" \
          -H "Content-Type: text/json; charset=utf-8" \
          -d @- <<EOF
        {
          "ref":"$REF",
          "description": "autodeploy",
          "required_contexts": [],
          "auto_merge": false,
          "environment": "$APPENV",
          "payload": {
            "environment": "$APP",
            "pulumi_stack": "$PULUMI_STACK",
            "app": "$APP"
          }
        }
        EOF
        )

        echo "response<<EOF" >> $GITHUB_OUTPUT
        echo "$response" >> $GITHUB_OUTPUT
        echo "EOF" >> $GITHUB_OUTPUT

with error

echo {
/home/runner/work/_temp/343c5f31-a8d6-4aba-92cf-92b61da19f67.sh: line 2: url:: command not found
{
Error: Process completed with exit code 127.

1oglop1 avatar Oct 25 '23 05:10 1oglop1

👋 @1oglop1 - This PR only merged a link referring to the multiline documentation. No examples or directions were changed in this PR. For more reference on this, you can check out the original issue. If that doesn't help, please reach out to the Actions community in our Community Discussions for support! 💛

cmwilson21 avatar Oct 25 '23 14:10 cmwilson21