docs icon indicating copy to clipboard operation
docs copied to clipboard

Update working-with-ssh-key-passphrases.md

Open victoremeka opened this issue 2 years ago • 4 comments

Added clearer directions to locating ~/.profile or ~/.bashrc file for windows users.

Why:

Closes ISSUE

What's being changed:

Line 43 in the content/authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md file.

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

victoremeka avatar Dec 22 '22 08:12 victoremeka

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Dec 22 '22 08:12 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Dec 22 '22 08:12 github-actions[bot]

@victoremeka - Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! :zap:

cmwilson21 avatar Dec 22 '22 18:12 cmwilson21

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Jan 26 '23 14:01 github-actions[bot]

@victoremeka my assessment from https://github.com/github/docs/pull/22822#discussion_r1099804188 still stands: I strongly advise to revise the patch so that it does not forget about literally all Windows users.

dscho avatar Feb 28 '23 18:02 dscho

I'm going to go ahead and close this PR out 💛

If you'd like to adjust the PR per the suggestion above to include Windows users, please do so and submit a new PR.

Thank you for your interest in improving GitHub Docs! :sparkling_heart:

cmwilson21 avatar Mar 03 '23 14:03 cmwilson21