docs icon indicating copy to clipboard operation
docs copied to clipboard

Double quote to prevent globbing issues

Open ashirazi2 opened this issue 2 years ago • 3 comments

Shell scripts should double-quote variables to prevent unintended word-splitting. See: https://www.shellcheck.net/wiki/SC2086

Why:

Closes #22794

What's being changed (if available, include any code snippets, screenshots, or gifs):

Properly quotes shell variables

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

ashirazi2 avatar Dec 20 '22 15:12 ashirazi2

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Dec 20 '22 15:12 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Dec 20 '22 15:12 github-actions[bot]

@ashirazi2 - Thanks for opening a PR to fix your issue. :sparkles:

I have edited your original message so that it will automatically link to the issue. :zap: For more information about linking issues, see "Linking a pull request to an issue".

I'll get this triaged for review! 👍

cmwilson21 avatar Dec 21 '22 14:12 cmwilson21

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Mar 01 '23 05:03 github-actions[bot]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Apr 21 '23 18:04 github-actions[bot]