docs icon indicating copy to clipboard operation
docs copied to clipboard

"Viewing large files in pull requests" section is not correct #21798

Open knlkshyp opened this issue 2 years ago • 3 comments

Added "some" to update the note

Why: There can be some cases where GitHub does render some Git LFS objects in pull requests. So updated the note in document.

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

view-large-files-in-pr

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

knlkshyp avatar Dec 16 '22 16:12 knlkshyp

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/working-with-files/managing-large-files/collaboration-with-git-large-file-storage.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Dec 16 '22 16:12 github-actions[bot]

@knlkshyp Thanks for submitting this PR and attaching the screenshots! ✨

I'll get this triaged for review! 💖

cmwilson21 avatar Dec 19 '22 22:12 cmwilson21

@knlkshyp Thanks for this fix! Your PR has been approved, however, our repo is frozen until Jan. 3rd for the holidays. We will get this merged down once the freeze has lifted ⚡

cmwilson21 avatar Dec 22 '22 14:12 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jan 03 '23 23:01 github-actions[bot]