docs
docs copied to clipboard
github
Update creating-redis-service-containers.md
Why:
Closes #22661
What's being changed (if available, include any code snippets, screenshots, or gifs):
I wanted the client.js code to work with the current version(4.x) of redis npm module. So I modified it by the following steps.
Step1 Modify client.js code to operate while maintaining v3 syntax in v4 using legacy mode. Step2 Fix some comments in client.js code. Step 3 Modify client.js code to promise-based async code using ES6 and disable legacy mode.
Before creating this pull request, I followed the guide and created a Redis client in my workflow to make sure that the modified code works. You can see the results in the following Redis runner example.
Check off the following:
- [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
- [x] For content changes, I have completed the self-review checklist.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Automatically generated comment ℹ️
This comment is automatically generated and will be overwritten every time changes are committed to this branch.
The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.
Content directory changes
You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
| Source | Preview | Production | What Changed |
|---|---|---|---|
actions/using-containerized-services/creating-redis-service-containers.md |
fpt ghec ghes@ 3.10 3.9 3.8 3.7 3.6 ghae |
fpt ghec ghes@ 3.10 3.9 3.8 3.7 3.6 ghae |
fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ChoHadam Thank you for opening a PR and linking it to your issue! ✨
I'll get this triaged for review! :zap:
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:
Stop
On Tue, Jan 17, 2023, 4:26 PM github-actions[bot] @.***> wrote:
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀
— Reply to this email directly, view it on GitHub https://github.com/github/docs/pull/22662#issuecomment-1386163075, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4VLLFHEWHL6AIFKIVOTR73WS4MATANCNFSM6AAAAAAS45ZQSI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:
Hi @hubwriter , I'm hadam.👋🏻 I'm one of the favorite readers of github docs. Thank you for merging this PR! I have some questions about your review.
Can you please let me know why it took so long for this PR to get reviewed? I just wonder if there wasn't enough time to review, or if there were difficulties understanding my PR (e.g. poor readability, lack of my English skills).
And I'm also curious why my PR was able to be merged all at once without much feedback.
This is my first open source contribution, so I think your comments will help me make better contributions in the future. 😊
Hi there @ChoHadam 👋
Apologies again that this PR went un-reviewed for so long. We usually review open-source contributions a lot quicker. Unfortunately, this one sat in our review backlog for a long time. There was no particular reason for this - just that we're a little under-staffed in the internal Docs team that reviews all PRs in this repo.
Because you provided great information about the reason for the change, in the issue you raised, and evidence of testing your work, I was able to merge this PR without asking for further work. This doesn't always happen but I was glad that, after leaving this in the backlog for so long, I was able just to go ahead and merge it.
I hope this doesn't put you off making further contributions to the GitHub docs in future. We really appreciate your work helping to keep the docs up to date. 🙇♂️
Thank you for your reply @hubwriter .
It was nice talking with you. It means a lot to me 😊
Have a nice day ☀️