docs
docs copied to clipboard
Client.js does not match the current version of redis npm module
Code of Conduct
- [X] I have read and agree to the GitHub Docs project's Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/using-containerized-services/creating-redis-service-containers
https://github.com/github/docs/blob/803715b128d5adf4f15e8e13bff2b0cfb86c66c1/content/actions/using-containerized-services/creating-redis-service-containers.md?plain=1#L279
What part(s) of the article would you like to see updated?
Client.js, the example code for testing Redis service container, does not match the current version of redis npm module.
Currently, running npm install redis
through terminal installs version 4.x(4.5.1) of redis by default. However, the Client.js code appears to have been written prior to redis v4.x. Comparing redis v4 and v3, the syntax and internal operation are completely different, as if creating a new package. For example, The redis v4 has been changed to operate asynchronously based on a promise object by default rather than based on a callback. More details can be found in the v3 to v4 Migration Guide.
Therefore, when the Client.js is executed on redis v4.x, the attached error occurs first, and other errors occur even if the legacy mode is applied like createClient({ legacyMode: true })
.
Additional information

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@ChoHadam Thank you for opening an issue and providing all this context. And for linking it to your PR! ✨
A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.
A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.
A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.
reopening as the PR is still waiting for review
A stale label has been added to this issue because it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.