docs icon indicating copy to clipboard operation
docs copied to clipboard

Client.js does not match the current version of redis npm module

Open ChoHadam opened this issue 2 years ago • 6 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-containerized-services/creating-redis-service-containers

https://github.com/github/docs/blob/803715b128d5adf4f15e8e13bff2b0cfb86c66c1/content/actions/using-containerized-services/creating-redis-service-containers.md?plain=1#L279

What part(s) of the article would you like to see updated?

Client.js, the example code for testing Redis service container, does not match the current version of redis npm module.

Currently, running npm install redis through terminal installs version 4.x(4.5.1) of redis by default. However, the Client.js code appears to have been written prior to redis v4.x. Comparing redis v4 and v3, the syntax and internal operation are completely different, as if creating a new package. For example, The redis v4 has been changed to operate asynchronously based on a promise object by default rather than based on a callback. More details can be found in the v3 to v4 Migration Guide.

Therefore, when the Client.js is executed on redis v4.x, the attached error occurs first, and other errors occur even if the legacy mode is applied like createClient({ legacyMode: true }).

Additional information

스크린샷 2022-12-13 오전 2 45 59

ChoHadam avatar Dec 13 '22 08:12 ChoHadam

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Dec 13 '22 08:12 welcome[bot]

@ChoHadam Thank you for opening an issue and providing all this context. And for linking it to your PR! ✨

cmwilson21 avatar Dec 13 '22 15:12 cmwilson21

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

github-actions[bot] avatar Feb 12 '23 16:02 github-actions[bot]

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

github-actions[bot] avatar Apr 15 '23 16:04 github-actions[bot]

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

github-actions[bot] avatar Jun 15 '23 16:06 github-actions[bot]

reopening as the PR is still waiting for review

cmwilson21 avatar Jun 19 '23 14:06 cmwilson21

A stale label has been added to this issue because it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

github-actions[bot] avatar Aug 18 '23 16:08 github-actions[bot]