docs icon indicating copy to clipboard operation
docs copied to clipboard

Update electron hyperlink

Open devcutler opened this issue 2 years ago â€ĸ 7 comments

Why:

Previous URL may have been 'https://electronjs.org/docs' but currently returns 404, intended page is now at 'https://electronjs.org/docs/latest'. This PR updates that hyperlink to the correct URL.

Former URL:

https://electronjs.org/docs

Current URL leading to the documentation for the latest version:

https://electronjs.org/docs/latest

devcutler avatar Nov 17 '22 19:11 devcutler

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Nov 17 '22 19:11 welcome[bot]

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Nov 17 '22 19:11 github-actions[bot]

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/actions-scripts/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* lib/graphql/** lib/redirects/** lib/rest/** lib/webhooks/** package*.json scripts/** translations/** content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Nov 17 '22 19:11 github-actions[bot]

Updated tests and translated pages to match, updating tests is disallowed so commit isn't passing checks.

devcutler avatar Nov 17 '22 19:11 devcutler

If you reset the translations changes; the test change should work just fine. Our translation pipeline is a separate process, and currently any changes to translations get overwritten when the pipeline runs each day.

heiskr avatar Nov 17 '22 20:11 heiskr

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/actions-scripts/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* lib/graphql/** lib/redirects/** lib/rest/** lib/webhooks/** package*.json scripts/** translations/** content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Nov 17 '22 20:11 github-actions[bot]

Change looks great! I don't know if locally you're able to run npm ci && npm run prettier but that should be all that's needed to merge :) Thanks!

heiskr avatar Nov 18 '22 19:11 heiskr

@arynthernium 👋 Just checking in here. Have you had a chance to apply the changes in the comment above?

cmwilson21 avatar Nov 23 '22 04:11 cmwilson21

Apologies for not seeing that sooner- I hadn't noticed the email notification. Ran the commands, committed and pushed with no issues. Thank you for reminding me and thanks for the good upkeep on this repo :)

devcutler avatar Nov 23 '22 04:11 devcutler

@arynthernium No problem at all! Thanks for making the update. There's several of our team out this week, but it'll be reviewed soon. ⚡

Thanks for your help in the upkeep for the docs! 💖

cmwilson21 avatar Nov 23 '22 17:11 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Nov 28 '22 13:11 github-actions[bot]

#22945

Aqeebrao avatar Jan 02 '23 05:01 Aqeebrao