docs icon indicating copy to clipboard operation
docs copied to clipboard

"Viewing large files in pull requests" section is not correct

Open AlekSi opened this issue 1 year ago • 5 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/repositories/working-with-files/managing-large-files/collaboration-with-git-large-file-storage#viewing-large-files-in-pull-requests

What part(s) of the article would you like to see updated?

GitHub does not render Git LFS objects in pull requests.

But it does render them (images, at least) just fine. For example, consider this PR: https://github.com/FerretDB/FerretDB/pull/1368/files You can see that it uses LFS: https://patch-diff.githubusercontent.com/raw/FerretDB/FerretDB/pull/1368.patch

Additional information

No response

AlekSi avatar Nov 04 '22 09:11 AlekSi

@AlekSi Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

cmwilson21 avatar Nov 04 '22 14:11 cmwilson21

Thanks @AlekSi, I chatted with the team about this, and it sounds like Git LFS objects are sometimes rendered and sometimes not. Rather than trying to explain the complicated criteria, let's just update that note to say this:

GitHub does not render some Git LFS objects in pull requests.

You or anyone else is welcome to open a PR doing so!

lecoursen avatar Nov 10 '22 14:11 lecoursen

hey @lecoursen i would love to work on this 😀

MahendraBishnoi29 avatar Nov 21 '22 03:11 MahendraBishnoi29

@MahendraBishnoi29 - You or anyone else is welcome to work on this 🎉

cmwilson21 avatar Nov 21 '22 17:11 cmwilson21

Hello, created PR for the fix https://github.com/github/docs/pull/22740 Thank you

knlkshyp avatar Dec 16 '22 16:12 knlkshyp