docs icon indicating copy to clipboard operation
docs copied to clipboard

Changed {:copy} function to remove any preceding $ before copying to clipboard

Open jo-tree opened this issue 2 years ago • 5 comments

Why:

Closes #21645

What's being changed (if available, include any code snippets, screenshots, or gifs):

I have changed the function that copies the string to the clipboard when {:copy} is used in an .md file. The change will remove, if it is present, the preceding $

Check off the following:

  • [ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

jo-tree avatar Oct 27 '22 07:10 jo-tree

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 27 '22 07:10 welcome[bot]

@jo-tree Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

cmwilson21 avatar Oct 27 '22 15:10 cmwilson21

👋 @jo-tree - Please see comment here and feel free to adjust this PR to reflect the request.

Thank you for your interest in improving the docs! 💖

cmwilson21 avatar Oct 28 '22 12:10 cmwilson21

@jo-tree thanks for opening this up. There was some work to fix this internally already in motion, so I'm checking in with those folks to see if we want to make this change.

rachmari avatar Nov 04 '22 23:11 rachmari

👋 @jo-tree - We are discussing possible improvements in the copy button internally, so I'm going to go ahead and close this issue now 💛

Thank you for opening the issue and inspiring the internal talks! ✨

cmwilson21 avatar Jan 12 '23 15:01 cmwilson21