docs icon indicating copy to clipboard operation
docs copied to clipboard

Update workflow-commands-for-github-actions.md

Open ujjwal-shekhar opened this issue 2 years ago â€ĸ 6 comments

Why:

Closes #21529

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added a Note at the end of the Multiline Strings section that clarifies it's use cases.

Check off the following:

  • [X] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [X] For content changes, I have completed the self-review checklist.

ujjwal-shekhar avatar Oct 25 '22 04:10 ujjwal-shekhar

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Oct 25 '22 04:10 github-actions[bot]

@ujjwal-shekhar Thanks so much for opening a PR! I edited your post slightly to link it to the issue. 🔗

I'll get this triaged for review :zap:

cmwilson21 avatar Oct 25 '22 14:10 cmwilson21

@ujjwal-shekhar Thanks so much for opening a PR! I edited your post slightly to link it to the issue. 🔗

I'll get this triaged for review ⚡

ujjwal-shekhar avatar Oct 26 '22 08:10 ujjwal-shekhar

The repo seems to be frozen, could you look in it. :)

ujjwal-shekhar avatar Oct 26 '22 08:10 ujjwal-shekhar

@ujjwal-shekhar We had a freeze while we merged some larger files. It's thawed now. Your PR is waiting for review. A writer will take a look at it soon 👀

cmwilson21 avatar Oct 26 '22 14:10 cmwilson21

👋 @ujjwal-shekhar - After checking into this a bit further, could you update the PR to reflect the comment here? Meaning, add a link to the setting an output parameter section, pointing people to the multi-line strings section section.

Check out our style guide's section on links for additional information.

We really appreciate your interest in improving the docs! 💖

cmwilson21 avatar Oct 26 '22 19:10 cmwilson21

@ujjwal-shekhar 👋 Checking in again, are you able to make the requested changes in the comment above? 💖

cmwilson21 avatar Nov 08 '22 19:11 cmwilson21

I'm going to close this PR for now. If you decide to update it as described by @cmwilson21 in https://github.com/github/docs/pull/21599#issuecomment-1292564504, feel free to reopen!

lecoursen avatar Nov 09 '22 19:11 lecoursen