docs
docs copied to clipboard
github
Align handling-plan-cancellations with billing-customers
Why:
https://docs.github.com/en/developers/github-marketplace/selling-your-app-on-github-marketplace/billing-customers#downgrades-and-cancellations has slightly different behaviour specified for cancelling than https://docs.github.com/en/developers/github-marketplace/using-the-github-marketplace-api-in-your-app/handling-plan-cancellations#step-2-deactivating-customer-accounts
This commit aligns the two so they say the same thing. It's possible this should be the other way around.
I opened a ticket at https://support.github.com/ticket/personal/0/1792415 about this too to clarify this.
Closes [issue link]
What's being changed (if available, include any code snippets, screenshots, or gifs):
Matching the cancellation behaviour between two docs.
Check off the following:
- [ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
- [ ] For content changes, I have completed the self-review checklist.
Automatically generated comment ℹ️
This comment is automatically generated and will be overwritten every time changes are committed to this branch.
The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.
Content directory changes
You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
| Source | Preview | Production | What Changed |
|---|---|---|---|
developers/github-marketplace/using-the-github-marketplace-api-in-your-app/handling-plan-cancellations.md |
fpt ghec |
fpt ghec |
fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@danielcompton Thanks for submitting a PR! Please keep us updated with your conversation with support.
In the mean time, I'll get this triaged for review!
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
I got a reply from support last year at https://support.github.com/ticket/1792415:
Thanks for writing in! I'm sorry for the delayed reply - it's definitely taken us longer to respond than we would have liked.
The steps mentioned in https://docs.github.com/en/developers/github-marketplace/selling-your-app-on-github-marketplace/billing-customers#downgrades-and-cancellations is the correct/expected behavior --when a Marketplace plan is canceled the app is not automatically uninstalled.
Sorry, about the confusion --the documentation is already working on getting that sorted.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
This is a gentle bump for the docs team that this PR is waiting for technical review.
Thanks for highlighting this issue and for the write-up @danielcompton, and I sincerely apologize that it took us this long to get back to you on this 💖.
I appreciate the confusion your PR is attempting to address, however the changes you’ve proposed aren’t always correct and appropriate. After chatting with the relevant GitHub teams internally and looking at related support tickets, we’ve come to the conclusion that the guidance for developers managing Marketplace cancellations isn’t always straight-forward and often requires assistance from GitHub Support.
We don’t want to risk creating a broken experience for customers by suggesting the wrong procedure, so we'll close this PR. Rest assured that if new information comes to hand, we’ll revisit improving our docs to address the different behavior you’ve highlighted here :bow:.
