docs icon indicating copy to clipboard operation
docs copied to clipboard

Clarify process for refreshing EOL's of existing checked-out repo HEAD

Open stephenskett opened this issue 3 years ago • 11 comments
trafficstars

Why:

Closes #21151

What's being changed (if available, include any code snippets, screenshots, or gifs):

The numbered list instructions for "Refreshing a repository after changing line endings" don't work as required for me when trying to convert line endings in the current working version of an existing checked-out repository, and were generally a little unclear.

The alternative solution which I have appended into point 2 in my updated version (derived from the highlighted Stackoverflow thread, which I've added to references section), fixes the issue I experienced with the method as currently described. I have added this in as an alternative sub-point, rather than replacing the existing stated method, as I assume this may be useful in other scenarios than mine? Open to suggestions on exact wording.

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • [ ] This pull request impacts the contribution experience
    • [ ] I have added the 'writer impact' label
    • [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

stephenskett avatar Oct 06 '22 17:10 stephenskett

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Oct 06 '22 17:10 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/getting-started-with-git/configuring-git-to-handle-line-endings.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Oct 06 '22 17:10 github-actions[bot]

Thanks for the PR and issue @stephenskett, I'll get this triaged for review! ✨

steveward avatar Oct 07 '22 14:10 steveward

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Oct 12 '22 19:10 github-actions[bot]

👋 @stephenskett - Just checking in to see if you've had a chance to consider @mattpollard's question here?

Thank you! 💖

cmwilson21 avatar Nov 14 '22 19:11 cmwilson21

👋 @stephenskett - Just checking in to see if you've had a chance to consider @mattpollard's question here?

Thank you! 💖

Hey Courtney, thanks for the reminder and sorry @mattpollard for the delay in my response - been a bit swamped work-wise recently! :grimacing: But yes, I have been thinking about your question RE: the specific scenarios where you'd use each method, and doing a few little tests to make sure I can give a clear description of what the exact parameters of my actual use-case are where I encountered a problem using the method in the previous version. And so... I'm just formulating my response now! :blush:

stephenskett avatar Nov 16 '22 13:11 stephenskett

Thanks for the explanation, @stephenskett! I'll return to this, and I intend to decide on a way forward this week.

mattpollard avatar Nov 28 '22 09:11 mattpollard

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Dec 26 '22 16:12 github-actions[bot]

@mattpollard, @cmwilson21 Can I just check, is there anything I can do to help speed the process along RE: resolving the queries with updating this docs-page? (I realise my suggested edits only deal with one particular aspect, but that they might have wider implications - so are there any specific issues I could potentially address with additional changes here / in a separate PR?)

stephenskett avatar Jan 09 '23 18:01 stephenskett

👋🏻 Thanks for the prod, @stephenskett! And happy new year 😄 My apologies: I didn't get a chance to return to this before the holidays, but I'm back and should be able to move this forward this week.

mattpollard avatar Jan 10 '23 10:01 mattpollard

@stephenskett 👋🏻 Thanks again for your patience here ❤️ I'm wondering if https://github.com/github/docs/pull/21154#discussion_r1069785101 might move us forward. Let me know!

mattpollard avatar Jan 13 '23 17:01 mattpollard

This is a gentle bump for the docs team that this PR is waiting for technical review.

github-actions[bot] avatar Feb 23 '23 16:02 github-actions[bot]

Hey @stephenskett 👋, have you had a chance to consider Matt's last comment?

cmwilson21 avatar Feb 24 '23 14:02 cmwilson21

Hey @cmwilson21, yes I responded in a thread comment, here. Do you / @mattpollard need any more info from me to move this forward? (It's quite a busy time for me right now but happy to help if I can!)

stephenskett avatar Feb 24 '23 22:02 stephenskett

@stephenskett Sorry about that! Followed the wrong thread 😄

Thanks for the additional comment above, too. We appreciate you working with us on this 💖

cmwilson21 avatar Feb 28 '23 16:02 cmwilson21

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Jun 16 '23 11:06 github-actions[bot]