docs icon indicating copy to clipboard operation
docs copied to clipboard

Update search result description for secret gists

Open gregdeane opened this issue 3 years ago • 3 comments

Why:

The documentation is not clear regarding secret gists appearing in search results.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added clarification regarding search results and secret gists. Secret gists do appear in the search results for the person who created them (if they are logged in).

A secret gist

Screenshot 2022-09-19 at 09 06 07

The secret gist above appears in search results when I am logged in.

Screenshot 2022-09-19 at 09 06 35

Check off the following:

  • [x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • [ ] This pull request impacts the contribution experience
    • [ ] I have added the 'writer impact' label
    • [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

gregdeane avatar Sep 19 '22 07:09 gregdeane

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Sep 19 '22 07:09 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/editing-and-sharing-content-with-gists/creating-gists.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Sep 19 '22 07:09 github-actions[bot]

@gregdeane Thanks so much for opening a PR! I'll get this triaged for review :zap:

cmwilson21 avatar Sep 19 '22 17:09 cmwilson21

@skedwards88 Great update! Much better now. Thank you.

gregdeane avatar Sep 27 '22 19:09 gregdeane

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Sep 28 '22 02:09 github-actions[bot]