docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix user.signingkey example

Open kariya-mitsuru opened this issue 3 years ago • 3 comments

Why:

Since the value of user.signingkey is passed unchanged to gpg's --local-user parameter, the fingerprint needs to be suffixed with an exclamation mark (!).

If a fingerprint is specified without an exclamation mark, it is simply ignored.

What's being changed:

Simply added ! to the sample code.

Check off the following:

  • [x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • [ ] This pull request impacts the contribution experience
    • [ ] I have added the 'writer impact' label
    • [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

kariya-mitsuru avatar Jun 20 '22 17:06 kariya-mitsuru

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 20 '22 17:06 welcome[bot]

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: .devcontainer/** .github/actions-scripts/** .github/workflows/** .github/CODEOWNERS assets/fonts/** data/graphql/** Dockerfile* lib/graphql/** lib/redirects/** lib/rest/** lib/webhooks/** lib/search/indexes/** package*.json scripts/** translations/** content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

github-actions[bot] avatar Jun 20 '22 17:06 github-actions[bot]

@kariya-mitsuru Thanks so much for opening a PR! I'll get this triaged for review ⚡

In the meantime, could you revert the changes to the translated files? We only change the English content in this repository, then the changes are passed over to translators using an external service.

janiceilene avatar Jun 28 '22 11:06 janiceilene

Thanks for proposing this change @kariya-mitsuru! ⚡ I'm going to make a few small edits to make it clear that including the ! is needed only when specifying a subkey, and then I'll merge this. 🎉

vgrl avatar Aug 18 '22 03:08 vgrl

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap:

github-actions[bot] avatar Aug 18 '22 04:08 github-actions[bot]