docs icon indicating copy to clipboard operation
docs copied to clipboard

default sign all commits with gpg key

Open l3nnartt opened this issue 2 years ago • 5 comments

Why:

This way all commits are automatically signed and you dont have to set it up in each project

What's being changed:

Check off the following:

  • [x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • [x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • [ ] This pull request impacts the contribution experience
    • [ ] I have added the 'writer impact' label
    • [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

l3nnartt avatar Jun 10 '22 18:06 l3nnartt

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Jun 10 '22 18:06 welcome[bot]

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server ghae: GitHub AE

github-actions[bot] avatar Jun 10 '22 18:06 github-actions[bot]

@l3nnartt Thanks so much for opening a PR! I'll get this triaged for review ⚡

janiceilene avatar Jun 13 '22 11:06 janiceilene

Hello? 👀

l3nnartt avatar Aug 09 '22 20:08 l3nnartt

Thanks for checking in on this. This is up on the board for review. Someone will take a look at it soon! 👀

We appreciate your patience as we are working through our backlog 💛

cmwilson21 avatar Aug 10 '22 17:08 cmwilson21

👋 @l3nnartt Thanks for your contribution! I've chatted with the team about your PR and I see that we already mention this command in the "Tips" callout in "Signing commits". Given that, and since it's an optional, specific Git configuration that we don't have many users asking about, we won't be making the suggested change. Because of this, I'm closing the PR.

Thanks again for your work and your interest in improving GitHub's documentation!

vgrl avatar Aug 17 '22 03:08 vgrl

alright, thanks for the detailed answer! :D

l3nnartt avatar Aug 17 '22 04:08 l3nnartt