docs icon indicating copy to clipboard operation
docs copied to clipboard

Indicate if runner names are temporaly unique within a given scope

Open jsoref opened this issue 2 years ago • 13 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#webhook-payload-object-50 https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

What part(s) of the article would you like to see updated?

https://github.com/github/docs/blob/e93864362002a180c7ec17eefdb8cb49efea9e40/data/reusables/actions/runner-name-description.md?plain=1#L1

It'd be nice if something clearly indicated if a runner name is temporaly unique within a given scope.

i.e. Can two runners running jobs at the same time for the same repository have the same name?

I think the answer is no. But I'm not sure.

Additional information

https://github.community/t/ref-head-in-reusable-workflows/203690/95?u=jsoref

jsoref avatar May 03 '22 16:05 jsoref

@jsoref Thanks so much for opening an issue! I'll triage this for the team to review :eyes:

ramyaparimi avatar May 04 '22 13:05 ramyaparimi

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert :eyes:

github-actions[bot] avatar Jun 29 '22 07:06 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Jul 06 '22 20:07 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Jul 14 '22 20:07 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Jul 22 '22 20:07 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Oct 14 '22 20:10 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Nov 14 '22 16:11 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Dec 13 '22 16:12 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Jan 11 '23 16:01 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Feb 09 '23 16:02 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Mar 10 '23 16:03 github-actions[bot]

I was able to register two runners with the same name, albeit at different levels. First, I registered a runner named runner1 at the repo level (in the repo's Default runner group).

Then, I went to an org-level runner group already shared with the repo where I registered runner1. I was able to register a second runner named runner1 within this org-level runner group.

At job-assignment time (as a result of the way the org-level runner group is configured), both of those runner1's are eligible to perform work on behalf of the repo.

jww3 avatar Mar 14 '23 12:03 jww3

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Apr 11 '23 16:04 github-actions[bot]

This is a gentle bump for the docs team that this issue is waiting for technical review.

github-actions[bot] avatar Jul 08 '23 16:07 github-actions[bot]

@jsoref - The link https://github.community/t/ref-head-in-reusable-workflows/203690/95?u=jsoref is no longer working so I'm not sure the context of why this came up. It sounds like we could add a little detail here if it would provide value but we shouldn't add information unless it's genuinely going to help folks out (we're sometimes criticized in feedback for giving too much detail). 😃

Maybe you could say a little more here about why this is needed?

hubwriter avatar Aug 07 '23 13:08 hubwriter

I have code that tries to find a running workflow and it's helpful to know if this field uniquely identifies a runner at a given point in time. Apparently, it does NOT, as while there might only be one runner by that name at a repository level, another could exist at the organization level and both could be running workflows for that repository at the same time.

jsoref avatar Aug 07 '23 13:08 jsoref

@jsoref - Thanks for clarifying.

I agree it would be useful to clarify in the reusable that the name may not be unique in a workflow run as runners at repository and organization level could use the same name.

If you, or anyone else reading this, would like to raise a pull request to make this change that would be great. Thanks again.

hubwriter avatar Aug 09 '23 09:08 hubwriter

Hey @hubwriter,

I have raised a PR: https://github.com/github/docs/pull/27747 with the changes suggested by you. Could you please take a look whenver you get a chance?

Also big thanks to @jsoref for addressing this issue.

Thanks!

electron97 avatar Aug 26 '23 08:08 electron97

@electron97 - Thanks for the PR! I'll get it triaged and on the review board 👍

cmwilson21 avatar Aug 28 '23 14:08 cmwilson21