docs icon indicating copy to clipboard operation
docs copied to clipboard

Incorrect command description in "adding GPG key" docs

Open vient opened this issue 3 years ago • 4 comments

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key

What part(s) of the article would you like to see updated?

Command description should be rewritten in Mac point 5 "If you aren't using the GPG suite...", Linux point 5 "To add your GPG key to your bash profile..." sections.

These commands do not add GPG keys to shell profile, instead they add an instruction to shell profile to correctly set GPG_TTY environment variable on startup. Without it GPG won't be able to ask user for key's password.

Additional information

No response

vient avatar Feb 05 '22 17:02 vient

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

welcome[bot] avatar Feb 05 '22 17:02 welcome[bot]

@vient Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

ramyaparimi avatar Feb 07 '22 13:02 ramyaparimi

A stale label has been added to this issue becuase it has been open for 60 days with no activity. To keep this issue open, add a comment within 3 days.

github-actions[bot] avatar Apr 08 '22 16:04 github-actions[bot]

Not fixed yet

vient avatar Apr 08 '22 21:04 vient

It looks like https://github.com/github/docs/pull/16181 may have resolved the concerns mentioned in this issue, so I'll close this now.

vgrl avatar Sep 13 '22 21:09 vgrl