details-dialog-element

details-dialog-element copied to clipboard

When the `` element is connected to the document as a child of a `` element rendered with `[open]`, trap focus immediately. In support of this change, extract the `trapFocus`...

seanpdoyle

koddsson

Should Dialog let contents overflow outside?

4

When an element inside `` is longer than the dialog, it results in a scroll on the dialog which isn't ideal: https://user-images.githubusercontent.com/1863771/158603253-bedb71b2-9115-4ab2-be9d-21f9bd7876ed.mov This can be reproduced in the `Dialog with...

siddharthkp

Consider a element as hidden if it's in a closed `` element. Closes https://github.com/github/details-dialog-element/issues/77

koddsson

Test for managing focus is failing

3

https://github.com/github/details-dialog-element/runs/5240152268?check_suite_focus=true This test appears to have been failing since https://github.com/github/details-dialog-element/actions/runs/1766435305 but it looks like older runs may have been failing silently as tests were not running. See for example this...

theinterned

Option to preventScroll on focus

2

I’m running into a problem where the calls to `focus()` are jumping the scroll around on my page. Specifically in Chrome with the dialogs inside of a sticky header. Changing...

evanminto

Initial focus should be set to the first focusable element

1

https://github.com/github/details-dialog-element/blob/59902d7e420866c30ee288fedcc4f3edfbf8351b/src/index.ts#L10-L17 Initial focus should be set to the first focusable element instead of the dialog element. > @jscholes: Placing focus on the close button is the correct behaviour if the...

muan