command icon indicating copy to clipboard operation
command copied to clipboard

When using a matrix strategy the actions fails in the post step

Open joerg opened this issue 6 months ago • 1 comments

Describe the Issue

When using a matrix strategy to run the job multiple times the actions post step fails all but once because it can not find the initial reaction that has been removed already by some other matrix run.

Action Configuration

jobs:
  something:
    strategy:
      matrix:
        runs:
          - a
          - b
    steps:
      - name: Check command in comment
        id: command
        uses: github/command@v2
        with:
          command: .plan
          allowed_contexts: "pull_request"

Relevant Actions Log Output

2025-06-25T07:24:32.1785017Z ##[error]HttpError: Not Found - https://docs.github.com/[email protected]/rest/reactions/reactions#delete-an-issue-comment-reaction
    at /__w/_actions/actions/command/v2/node_modules/@octokit/core/node_modules/@octokit/request/dist-node/index.js:125:1
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at postReactions (/__w/_actions/actions/command/v2/src/functions/post-reactions.js:8:1)
    at post (/__w/_actions/actions/command/v2/src/functions/post.js:65:1)
2025-06-25T07:24:32.1802743Z ##[error]Not Found - https://docs.github.com/[email protected]/rest/reactions/reactions#delete-an-issue-comment-reaction

Extra Information

No response

joerg avatar Jun 25 '25 08:06 joerg

👋 @joerg I have personally never used, or have seen this action used in a matrix strategy before so this is a good find! Seems like a classic race condition to me.

I could see it making a lot of sense to just gracefully handle situations like this where HttpError: Not Found is just converted into a log message (maybe just a warning?) and the post steps continue rather than failing.

What are your thoughts here since I think you are the first user to be playing around with github/command in a matrix?

GrantBirki avatar Aug 05 '25 05:08 GrantBirki