codeql icon indicating copy to clipboard operation
codeql copied to clipboard
verified publisher icon github

Go 1.23 fixups

Open smowton opened this issue 1 year ago • 5 comments

smowton avatar Aug 30 '24 13:08 smowton

Positive DCA results: https://github.com/github/codeql-dca-main/issues/23447

Now running QA: https://github.com/github/codeql-qa-ops/issues/191

smowton avatar Sep 02 '24 21:09 smowton

Did you see that https://github.com/bazelbuild/rules_go/releases/tag/v0.50.0 was released? That way, we should be able to fully rely on upstream again.

criemen avatar Sep 03 '24 08:09 criemen

@criemen note that the main PR for this is #17058 and this is just Chris' additions to it. The rules_go fix there was PR-ed in by @redsun82 a little while ago. I don't think anyone on our team keeps tabs on new releases of the Bazel libraries.

mbg avatar Sep 03 '24 11:09 mbg

Thanks, commented there instead!

criemen avatar Sep 03 '24 11:09 criemen

For future reference: DCA results were good, but with the addition of the stats commit they are terrible. A stats update really ought to happen due to adding a new table, but evidently it has caused a bad join order somewhere important. This will also apply to smaller PRs that are adding tables component_tags etc.

smowton avatar Sep 20 '24 15:09 smowton

This has been superseded by https://github.com/github/codeql/pull/18283, which is a rebased version with some fixes.

owen-mc avatar Jan 28 '25 11:01 owen-mc