codeql icon indicating copy to clipboard operation
codeql copied to clipboard

Rewrite recommendations for the query `cpp/no-space-for-terminator`

Open rvermeulen opened this issue 9 months ago • 1 comments

This PR aims to improve the recommendations with the following changes:

  • Replace segmentation fault with crash that is platform agnostic (I think segmentation fault is not really a thing on Windows).
  • Replace security vulnerability with malicious code execution. This provides a range of issues, because a crash (previously segmentation fault) could also be considered a security vulnerability. Namely a DOS.
  • Removed the additional note on stack allocated arrays which seem confusing because we are always talking about buffers allocated on the heap.

rvermeulen avatar May 24 '24 23:05 rvermeulen