codeql C++: Output destructors of temporary objects

Feb 29 '24 15:02 jketema

I'd expect to see a destructor call for the temporary string at line 1369 of ir.cpp. The AST otherwise looks good to me.

Feb 29 '24 19:02 rdmarsh2

I'd expect to see a destructor call for the temporary string at line 1369 of ir.cpp.

This turns out to be a very interesting case. It's a temporary, by the lifetime is at block scope, not expression scope.

Mar 01 '24 09:03 jketema

very interesting case. It's a temporary, by the lifetime is at block scope, not expression scope.

This is now fixed.

Mar 04 '24 10:03 jketema

This PR is now just test updates. All the other parts have been merged into main in separate PRs.

Mar 14 '24 08:03 jketema

Closing in favour of https://github.com/github/codeql/pull/15978. That's the 3rd in a series of PRs, which mostly does what was done here, except for some synthetic destructor generation related to throws (that'll be a separate PR).

Mar 20 '24 10:03 jketema