codeql-coding-standards icon indicating copy to clipboard operation
codeql-coding-standards copied to clipboard

A1-1-2: does not detect compilations that suppress warnings with `-w` flag

Open MichaelRFairhurst opened this issue 1 year ago • 0 comments

Affected rules

  • A1-1-2

Description

Currently, A1-1-2 reports compilations that do not specify at least one flag of type -Wfoo. However, clang and gcc both give priority to -w (the flag to suppress errors). Therefore, -w -Wfoo will not show warnings, and should be captured by A1-1-2, but it currently is not.

Note, codeql run test seems to automatically and unconditionally extract with a -w flag. Therefore, it seems that creating a set of compliant/non compliant tests cannot be done with the current test infrastructure.

Example

g++ -w -Wformat test.cpp
clang++ -w -Wformat test.cpp

MichaelRFairhurst avatar Sep 17 '24 20:09 MichaelRFairhurst